[Security] Add tokenSource parameter for CSRF token validation sources
#21363
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webda2l
force-pushed
the
isCsrfTokenValid
branch
2 times, most recently
from
f7ce0e8 to
d885b0c
Compare
webda2l
force-pushed
the
isCsrfTokenValid
branch
from
d885b0c to
f2a80ed
Compare
94noni
reviewed
Sep 10, 2025
|
|
||
| * ``IsCsrfTokenValid::SOURCE_PAYLOAD`` (default): request payload (POST body / json) | ||
| * ``IsCsrfTokenValid::SOURCE_QUERY``: query string | ||
| * ``IsCsrfTokenValid::SOURCE_HEADER``: request headers |
There was a problem hiding this comment.
Suggested change
| * ``IsCsrfTokenValid::SOURCE_HEADER``: request headers | |
| * ``IsCsrfTokenValid::SOURCE_HEADER``: request header |
As it checks only one no?
There was a problem hiding this comment.
Yes. Fixed while merging. Thanks!
94noni
reviewed
Sep 10, 2025
| #[IsCsrfTokenValid( | ||
| 'delete-item', | ||
| tokenKey: 'token', | ||
| tokenSource: IsCsrfTokenValid::SOURCE_PAYLOAD | IsCsrfTokenValid::SOURCE_QUERY |
There was a problem hiding this comment.
Suggestion, but perhaps overkill
Document one simple source and one with combination?
There was a problem hiding this comment.
I left it "as is" because I think it's simple enough to understand it. Thanks.
94noni
approved these changes
Sep 10, 2025
|
Thanks David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21362